Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bmfont error in subdomain and setting color invalid. #3731

Merged

Conversation

@caryliu1999
Copy link
Contributor

commented Jan 9, 2019

Re: cocos-creator/2d-tasks#1033

Changes:
Fix bmfont error in subdomain and setting color invalid.

@@ -27,9 +27,6 @@ const WHITE = (255<<16) + (255<<8) + 255;
const MAX_CANVAS_COUNT = 32;

function colorizedFrame (canvas, texture, color, sx, sy, sw, sh) {
if (cc.sys.browserType === cc.sys.BROWSER_TYPE_WECHAT_GAME_SUB) {
return canvas;
}

This comment has been minimized.

Copy link
@pandamicro

pandamicro Jan 9, 2019

Member

原始代码中找不到这段,所以被添加一定是有原因的。。。可是我真的想不起来了,而且找历史也没找到添加这段的原因。。。有点尴尬

This comment has been minimized.

Copy link
@pandamicro

pandamicro Jan 10, 2019

Member

先合并吧,如果用户遇到问题,先反馈对方,不改颜色可以规避

@pandamicro pandamicro merged commit 1ca330b into cocos-creator:v2.0-release Jan 10, 2019
1 check passed
1 check passed
ci/circleci: test Your tests passed on CircleCI!
Details
@caryliu1999 caryliu1999 deleted the caryliu1999:v2.0-release-bmf-fix branch Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.