Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the problem that the letter y was cropped in CHAR mode. #4809

Merged
merged 3 commits into from Jul 4, 2019

Conversation

@caryliu1999
Copy link
Contributor

commented Jul 4, 2019

No description provided.

@@ -558,7 +558,7 @@ module.exports = {
letterPosition.x = letterX;
}

letterPosition.y = nextTokenY - letterDef.offsetY * _bmfontScale + _labelInfo.margin;
letterPosition.y = nextTokenY - letterDef.offsetY * _bmfontScale + _labelInfo.margin + _fontSize * textUtils.BASELINE_RATIO / 2;

This comment has been minimized.

Copy link
@jareguo

jareguo Jul 4, 2019

Contributor

这边为什么要 /2

This comment has been minimized.

Copy link
@caryliu1999

caryliu1999 Jul 4, 2019

Author Contributor

1562221780896

@Jno1995

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

这个问题在原生游戏上也存在异常。

@jareguo jareguo merged commit 82f7406 into cocos-creator:v2.1.2 Jul 4, 2019

1 check passed

ci/circleci: test Your tests passed on CircleCI!
Details

@caryliu1999 caryliu1999 deleted the caryliu1999:v2.1.2-fix-lettery branch Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.