Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node group bug #5723

Conversation

@sunnylanwanjun
Copy link
Contributor

sunnylanwanjun commented Nov 12, 2019

issue:cocos-creator/2d-tasks#2045

修复子节点group与父节点group同步的bug
https://forum.cocos.com/t/2-2-0-child-group-group/84960/2
之前做native renderer时,错误的理解导致的bug
native renderer pr:7b952dd

@jareguo

This comment has been minimized.

Copy link
Contributor

jareguo commented Nov 12, 2019

是不是应该有点注释呢?这样后面重构的人就不会又理解错了

@sunnylanwanjun

This comment has been minimized.

Copy link
Contributor Author

sunnylanwanjun commented Nov 13, 2019

嗯,加了,只是觉得只要pr注释写详细就好了,接锅的人看对应的修改pr就能明白。

@holycanvas

This comment has been minimized.

Copy link
Contributor

holycanvas commented Nov 13, 2019

看其他开源项目,有些项目是在issue里面写得很详细,注释的地方就只用写 issue #5723 。但是这就要求pr或者issue里面得全部用英文写描述了,感觉对我们来说还是挺吃力的

@sunnylanwanjun

This comment has been minimized.

Copy link
Contributor Author

sunnylanwanjun commented Nov 13, 2019

以后pr里面一份英文注解,一份中文注解,中文用于国内发布版本,英文用于海外。
额,其实这点英文没什么的,实在不行,可以用工具。
话说,有道翻译是真的厉害,接近人翻。。。。。

@sunnylanwanjun

This comment has been minimized.

Copy link
Contributor Author

sunnylanwanjun commented Nov 13, 2019

image
就像这句话,简直牛逼得不行。。。。

@holycanvas

This comment has been minimized.

Copy link
Contributor

holycanvas commented Nov 13, 2019

image
这行也太搞了吧,看样子口语翻译比较难

@holycanvas

This comment has been minimized.

Copy link
Contributor

holycanvas commented Nov 13, 2019

我一般用有道翻一次,再修改一下语法

@holycanvas

This comment has been minimized.

Copy link
Contributor

holycanvas commented Nov 13, 2019

@holycanvas holycanvas requested a review from caryliu1999 Nov 14, 2019
@holycanvas holycanvas merged commit a008925 into cocos-creator:v2.2.1-release Nov 15, 2019
1 check passed
1 check passed
ci/circleci: test Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.