Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash loading scene while editBox is on editing on Mac #5804

Merged
merged 3 commits into from Nov 28, 2019

Conversation

@umbrellaPP
Copy link
Contributor

umbrellaPP commented Nov 28, 2019

Re: cocos-creator/2d-tasks#2133

changeLog:

@umbrellaPP umbrellaPP requested review from holycanvas and Jno1995 Nov 28, 2019
@umbrellaPP umbrellaPP changed the title 221 editbox fix crash loading scene while editBox is on editing on Mac Nov 28, 2019
@holycanvas

This comment has been minimized.

Copy link
Contributor

holycanvas commented Nov 28, 2019

Destroy的时候会触发 onDisable 么

@umbrellaPP

This comment has been minimized.

Copy link
Contributor Author

umbrellaPP commented Nov 28, 2019

onDisable 会在 节点销毁 之前触发

@holycanvas

This comment has been minimized.

Copy link
Contributor

holycanvas commented Nov 28, 2019

之前之所以需要 #5748 的修改是因为当时的disable不会隐藏键盘?

@umbrellaPP

This comment has been minimized.

Copy link
Contributor Author

umbrellaPP commented Nov 28, 2019

之前之所以需要 #5748 的修改是因为当时的disable不会隐藏键盘?

是因为 微信和原生上没有实现 disable,只有 web 上实现了。所以 web 没这个问题 cocos-creator/2d-tasks#2082

@jareguo

This comment has been minimized.

Copy link
Contributor

jareguo commented Nov 28, 2019

得同步给 Runtime 进行修改

@umbrellaPP

This comment has been minimized.

Copy link
Contributor Author

umbrellaPP commented Nov 28, 2019

@@ -52,19 +55,24 @@ let EditBoxImplBase = cc.Class({
},

setTabIndex (index) {
// Only support on Web platform
// Only support on Web platform

This comment has been minimized.

Copy link
@jareguo

jareguo Nov 28, 2019

Contributor

这个注释我觉得没有意义,子类有就是支持,没有就是不支持

PP
@jareguo jareguo merged commit f943a87 into cocos-creator:v2.2.1-release Nov 28, 2019
1 check was pending
1 check was pending
ci/circleci: test CircleCI is running your tests
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.