Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize animation performance #12308

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

SantyWang
Copy link
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -48693,9 +48693,13 @@
             parseTrsPath(): {
                 node: string;
                 property: "scale" | "eulerAngles" | "position" | "rotation";
             } | null;
-            createRuntimeBinding(target: unknown, poseOutput: _cocos_core_animation_pose_output__PoseOutput | undefined, isConstant: boolean): _cocos_core_animation_tracks_track__RuntimeBinding | null;
+            createRuntimeBinding(target: unknown, poseOutput: _cocos_core_animation_pose_output__PoseOutput | undefined, isConstant: boolean): _cocos_core_animation_tracks_track__RuntimeBinding | {
+                target: any;
+                setValue: any;
+                getValue: any;
+            } | null;
             isMaskedOff(mask: AnimationMask): boolean;
         }
         export type _cocos_core_animation_tracks_track__Binder = (binding: _cocos_core_animation_tracks_track__TrackBinding) => undefined | _cocos_core_animation_tracks_track__RuntimeBinding;
         export type _cocos_core_animation_exotic_animation_exotic_animation__FloatArray = Float32Array | Float64Array;

@SantyWang
Copy link
Contributor Author

SantyWang commented Aug 3, 2022

UITransformAnimation BenchMark
Android WebMobile

number before after
2300 40 57
3100 30 43
4500 21 30

Android

number before after
2100 47 58
3100 32 44
4000 25 33

@SantyWang SantyWang changed the title optimize animation optimize animation performance Aug 3, 2022
@pandamicro
Copy link
Contributor

It does have a general impact on all animation logics, I suggest it to be considered in v3.6.1

@SantyWang SantyWang changed the base branch from v3.6.0 to v3.6.1 August 9, 2022 03:53
@pandamicro pandamicro merged commit 1259f6c into cocos:v3.6.1 Aug 11, 2022
@SantyWang SantyWang deleted the v3.6.0-animation-perf branch September 8, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants