Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.6.1] Fix potential crash in Node::isChildOf #12493

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

dumganhar
Copy link
Contributor

Cherrypick from #12473

Re: #12470

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar requested a review from minggo August 21, 2022 06:13
@github-actions
Copy link

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build runned result crashScene FailScene
ios_release PASS PASS FAIL NA BuildTimeConstantsTest
Mac_debug PASS PASS FAIL NA BuildTimeConstantsTest
WebMobile_debug PASS PASS FAIL NA BuildTimeConstantsTest

@github-actions
Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build runned result crashScene FailScene
WebDesktop_release PASS PASS FAIL NA BuildTimeConstantsTest
WebMobile_release PASS PASS FAIL NA BuildTimeConstantsTest
Win32_release PASS PASS FAIL NA BuildTimeConstantsTest
Android_debug PASS PASS FAIL NA BuildTimeConstantsTest

@minggo minggo merged commit e4cd83e into cocos:v3.6.1 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants