Skip to content

3.6.1 Android dont link unused libraries #12537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Conversation

PatriceJiang
Copy link
Contributor

@PatriceJiang PatriceJiang commented Aug 24, 2022

Re: #

Changelog

Skip unused libraries to reduce package size

cocos/cocos-engine-external#283

  • glslang
  • websocket
  • tbb

Android set compile flags with cocos_engine rather than user project.


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@PatriceJiang PatriceJiang added this to the V3.6.1 milestone Aug 24, 2022
@PatriceJiang PatriceJiang changed the title 3.6.1 Update external-config.json 3.6.1 Android dont link unused libraries Aug 24, 2022
@PatriceJiang
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

Interface Check Report

This pull request does not change any public interfaces !

@github-actions
Copy link

@PatriceJiang, Please check the result of run test cases:

Task Details

Platform build runned result crashScene FailScene
ios_release PASS PASS PASS NA
Mac_debug PASS PASS PASS NA
WebMobile_debug PASS PASS PASS NA

@github-actions
Copy link

@PatriceJiang, Please check the result of run test cases:

Task Details

Platform build runned result crashScene FailScene
WebDesktop_release PASS PASS PASS NA
WebMobile_release PASS PASS PASS NA
Win32_release PASS PASS PASS NA
Android_debug PASS PASS PASS NA

@PatriceJiang
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

@PatriceJiang, Please check the result of run test cases:

Task Details

Platform build runned result crashScene FailScene
ios_release PASS PASS PASS NA
Mac_debug PASS PASS PASS NA
WebMobile_debug PASS PASS PASS NA

@github-actions
Copy link

@PatriceJiang, Please check the result of run test cases:

Task Details

Platform build runned result crashScene FailScene
WebDesktop_release PASS PASS PASS NA
WebMobile_release PASS PASS PASS NA
Win32_release PASS PASS PASS NA
Android_debug PASS PASS PASS NA

@minggo minggo merged commit a325697 into cocos:v3.6.1 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants