V3.6.1 audio source leak #12592
Merged
V3.6.1 audio source leak #12592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cocos-robot run test cases |
PPpro
reviewed
Aug 29, 2022
cocos/audio/audio-source.ts
Outdated
| @@ -329,8 +329,9 @@ export class AudioSource extends Component { | |||
| if (this.state === AudioState.PLAYING) { | |||
| this._player?.stop().catch((e) => {}); | |||
| } | |||
| const pIayer = this._player; | |||
There was a problem hiding this comment.
Suggested change
| const pIayer = this._player; | |
| const player = this._player; |
Interface Check ReportThis pull request does not change any public interfaces ! |
PPpro
approved these changes
Aug 29, 2022
|
@timlyeee, Please check the result of
Task Details
|
|
@timlyeee, Please check the result of
Task Details
|
|
@timlyeee, Please check the result of
Task Details
|
dumganhar
approved these changes
Aug 30, 2022
|
@timlyeee, Please check the result of
Task Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: ##12455
Changelog
thisis deleted.Continuous Integration
This pull request:
Compatibility Check
This pull request: