spine/dragonbones renderdata use rgba8 color format #12619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -2864,8 +2864,9 @@
* 2. 二维贴图 UV 属性（Float32）
* 3. RGBA 颜色属性（Float32）
*/
export const vfmtPosUvColor: gfx.Attribute[];
+ export const vfmtPosUvColor4B: gfx.Attribute[];
/**
* @en Vertex format with the following layout
* 1. Vector 3 position attribute (Float32)
* 2. Vector 2 uv attribute (Float32)
@@ -2877,8 +2878,9 @@
* 3. 第一套 RGBA 颜色属性（Float32）
* 3. 第二套 RGBA 颜色属性（Float32）
*/
export const vfmtPosUvTwoColor: gfx.Attribute[];
+ export const vfmtPosUvTwoColor4B: gfx.Attribute[];
}
/**
* @zh
* UI 渲染流程
|
SantyWang
reviewed
Aug 31, 2022
| @@ -227,7 +227,7 @@ export class BaseRenderData { | |||
| */ | |||
| export class RenderData extends BaseRenderData { | |||
| public static add (vertexFormat = vfmtPosUvColor, accessor?: StaticVBAccessor) { | |||
| const rd = new RenderData(vertexFormat); | |||
There was a problem hiding this comment.
RenderData's contructor do not accept accessor parameter
cocos/2d/renderer/mesh-buffer.ts
Outdated
| } else if (attrs === vfmtPosUvTwoColor4B) { | ||
| vfm = Vertex2DFormat.V3F_T2F_C4B_C4B; | ||
| } | ||
| this._nativeObj.initialize(device, vfm, vFloatCount, iCount); |
There was a problem hiding this comment.
Why don't pass attributes array
| void UIMeshBuffer::initialize(gfx::Device* /*device*/, ccstd::vector<gfx::Attribute*>&& attrs, uint32_t /*vFloatCount*/, uint32_t /*iCount*/) { | ||
| if (attrs.size() == 4) { | ||
| _attributes.push_back(gfx::Attribute{gfx::ATTR_NAME_COLOR2, gfx::Format::RGBA32F}); | ||
| void UIMeshBuffer::initialize(gfx::Device* /*device*/,Vertex2DFormat vfm, uint32_t /*vFloatCount*/, uint32_t /*iCount*/) { |
There was a problem hiding this comment.
Need to figure out why can not pass array
There was a problem hiding this comment.
in c++ get a item value with null vector. i think jsb not convert class.
i have no time to find root cause, so use a simple way to avoid this problem
SantyWang
approved these changes
Sep 1, 2022
zhakesi
changed the title
cocos-robot
pushed a commit
to cocos-robot/engine
that referenced
this pull request
Sep 1, 2022
dumganhar
pushed a commit
that referenced
this pull request
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spine and dragonbones use simple color 4byte