fixed #12625: The prototype chain for mesh.maxPosition is not Vec3 on version 3.6.0 #12628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c3 on version 3.6.0
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -3204,15 +3204,15 @@
* @en The minimum position of all vertices in the mesh
* @zh （各分量都）小于等于此网格任何顶点位置的最大位置。
* @deprecated Please use [[struct.minPosition]] instead
*/
- get minPosition(): math.Vec3 | undefined;
+ get minPosition(): Readonly<math.Vec3> | undefined;
/**
* @en The maximum position of all vertices in the mesh
* @zh （各分量都）大于等于此网格任何顶点位置的最大位置。
* @deprecated Please use [[struct.maxPosition]] instead
*/
- get maxPosition(): math.Vec3 | undefined;
+ get maxPosition(): Readonly<math.Vec3> | undefined;
/**
* @en The struct of the mesh
* @zh 此网格的结构。
*/
|
|
@cocos-robot run test cases |
|
@dumganhar, Please check the result of
Task Details
|
|
@dumganhar, Please check the result of
Task Details
|
PatriceJiang
reviewed
Sep 1, 2022
| @@ -398,7 +398,8 @@ export class MeshRenderer extends ModelRenderer { | |||
|
|
|||
| public onGeometryChanged () { | |||
| if (this._model && this._mesh) { | |||
| this._model.createBoundingShape(this._mesh.struct.minPosition, this._mesh.struct.maxPosition); | |||
| const meshStruct = this._mesh.struct; | |||
There was a problem hiding this comment.
Is the purpose here to reduce temporary objects for GC?
There was a problem hiding this comment.
Yes, also a bit of tweak for performance since less property visit.
minggo
approved these changes
Sep 1, 2022
|
@cocos-robot run test cases |
PatriceJiang
approved these changes
Sep 1, 2022
|
@dumganhar, Please check the result of
Task Details
|
|
@dumganhar, Please check the result of
Task Details
|
stanleyljl
approved these changes
Sep 1, 2022
cocos-robot
pushed a commit
to cocos-robot/engine
that referenced
this pull request
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #12625
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: