[Bug fix] Add detections for innerAudioContext. #13162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
timlyeee
commented
Oct 27, 2022
timlyeee
commented
- Pausing an innerAudioContext which is not fully initialized, the currentTime might be null.-https://github.com/cocos/3d-tasks/issues/14080
- Pause means nothing for a stopped audio
- InnerAudioContext.destroy behavior is insane that it might not stop the audio immediatly,
Interface Check ReportThis pull request does not change any public interfaces ! |
minggo
reviewed
Oct 27, 2022
minggo
approved these changes
Nov 18, 2022
PPpro
suggested changes
Nov 18, 2022
1. Pausing an innerAudioContext which is not fully initialized, the currentTime might be null.-https://github.com/cocos/3d-tasks/issues/14080 2. Pause means nothing for a stopped audio 3. InnerAudioContext.destroy behavior is insane that it might not stop the audio immediatly,
PPpro
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.