Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize spine/dragonbones material update #13416

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

zhakesi
Copy link
Contributor

@zhakesi zhakesi commented Nov 16, 2022

@zhakesi zhakesi requested a review from SantyWang November 16, 2022 15:41
@github-actions
Copy link

github-actions bot commented Nov 16, 2022

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -31623,10 +31623,12 @@
              */
             _requestDrawData(material: Material, texture: Texture2D, indexOffset: number, indexCount: number): ArmatureDisplayDrawData;
             destroyRenderData(): void;
             getMaterialForBlend(src: gfx.BlendFactor, dst: gfx.BlendFactor): renderer.MaterialInstance;
+            protected _updateBuiltinMaterial(): Material;
             get customMaterial(): Material | null;
             set customMaterial(val: Material | null);
+            protected updateMaterial(): void;
             protected _render(batcher: UI): void;
             __preload(): void;
             _init(): void;
             /**
@@ -44238,10 +44240,12 @@
         export class Skeleton extends UIRenderer {
             static SpineSocket: typeof SpineSocket;
             static AnimationCacheMode: typeof AnimationCacheMode;
             get drawList(): memop.RecyclePool<SkeletonDrawData>;
+            protected _updateBuiltinMaterial(): Material;
             get customMaterial(): Material | null;
             set customMaterial(val: Material | null);
+            protected updateMaterial(): void;
             /**
              * @en The skeletal animation is paused?
              * @zh 该骨骼动画是否暂停。
              * @property paused

@SantyWang SantyWang merged commit 011a71f into cocos:v3.6.3 Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants