Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix instancing use jointTextureLayout #13418

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

zhakesi
Copy link
Contributor

@zhakesi zhakesi commented Nov 17, 2022

@github-actions
Copy link

github-actions bot commented Nov 17, 2022

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -42810,8 +42810,9 @@
         protected _parent: SkeletalAnimation | null;
         protected _curvesInited: boolean;
         constructor(clip: AnimationClip, name?: string);
         initialize(root: Node): void;
+        protected onPlay(): void;
         /**
          * @internal This method only friends to `SkeletalAnimation`.
          */
         setUseBaked(useBaked: boolean): void;

@zhakesi zhakesi force-pushed the v3.6.3-fix-animation branch 3 times, most recently from 1f09804 to 7403e31 Compare November 18, 2022 04:54
@@ -85,6 +86,19 @@ export class SkeletalAnimationState extends AnimationState {
this.setUseBaked(baked);
}

@override
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need this

@zhakesi zhakesi force-pushed the v3.6.3-fix-animation branch from 7403e31 to b6d8300 Compare November 18, 2022 06:05
@zhakesi zhakesi requested a review from shrinktofit November 18, 2022 06:06
@SantyWang SantyWang merged commit 64f869f into cocos:v3.6.3 Nov 23, 2022
@zhakesi zhakesi deleted the v3.6.3-fix-animation branch March 2, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants