[fix] physics-2d contact disable not working #15149 (#15158) #15224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [fix] physics-2d contact disable not working cocos#15149 * tweaks and add docs
SantyWang
reviewed
May 30, 2023
| @@ -87,17 +95,26 @@ export class PhysicsContactListener extends b2.ContactListener { | |||
| public finalizeContactEvent () { | |||
| PhysicsContactListener._contactMap.forEach((contact: PhysicsContact, key: string) => { | |||
| //console.log('forEach', key, collision); | |||
|
|
|||
| // emit collision event | |||
| if (!contact.disabled || contact.status === Contact2DType.BEGIN_CONTACT) { //BEGIN_CONTACT always emits | |||
There was a problem hiding this comment.
Why always emit event when begin contact.
There was a problem hiding this comment.
Why always emit event when begin contact.
PhysicsContact is destroyed when ref decreases to 0, and not recycled. User can never get a PhysicsConact before BeginContact to disable it. However this check seems redundant, which I think can be removed.
There was a problem hiding this comment.
It is still not fixed contact.disable in cocos creator 3.7.4 still not working @lealzhan
SantyWang
approved these changes
May 30, 2023
cocos-robot
pushed a commit
to cocos-robot/engine
that referenced
this pull request
May 31, 2023
minggo
pushed a commit
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fix] physics-2d contact disable not working Physics2d contact disable not working since 3.7.1 #15149
tweaks and add docs
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: