Skip to content

[v3.8.6] Fix toString for math types - #18060

Merged
dumganhar merged 2 commits into
cocos:v3.8.6from
dumganhar:386-fix-vec-toString
Dec 24, 2024
Merged

[v3.8.6] Fix toString for math types#18060
dumganhar merged 2 commits into
cocos:v3.8.6from
dumganhar:386-fix-vec-toString

Conversation

@dumganhar

Copy link
Copy Markdown
Contributor

Re: https://forum.cocosengine.org/t/cocos-creator-3-8-5-forum-version-12-04/61483/9?u=dumganhar

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar
dumganhar requested a review from minggo December 19, 2024 02:16
@dumganhar

Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

@github-actions

github-actions Bot commented Dec 19, 2024

Copy link
Copy Markdown

👍 Package size ⤵ -124 bytes, old: 5442241, new: 5442117

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -15678,8 +15678,13 @@
              * @en Calculates the squared length of the quaternion
              * @zh 求四元数长度平方
              */
             lengthSqr(): number;
+            /**
+             * @en Return the information of the quaternion in string.
+             * @zh 返回当前四元数的字符串表示。
+             */
+            toString(): string;
         }
         export function quat(other: Quat): Quat;
         export function quat(x?: number, y?: number, z?: number, w?: number): Quat;
         /**

@github-actions

Copy link
Copy Markdown

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL event-info,touch-event,coordinate-ui-ui
ios PASS PASS FAIL event-info,touch-event,coordinate-ui-ui
mac PASS PASS FAIL event-info,mouse-event,touch-event,scroll-view-scroll-to-offset,coordinate-ui-ui

@github-actions

Copy link
Copy Markdown

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS FAIL event-info,mouse-event,touch-event,coordinate-ui-ui
android PASS PASS FAIL event-first,event-info,touch-event,scroll-view-scroll-to-offset,coordinate-ui-ui
wechatgame PASS PASS FAIL event-info,touch-event,BuildTimeConstantsTest,coordinate-ui-ui

@dumganhar

Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

@github-actions

Copy link
Copy Markdown

@dumganhar, Please check the result of run test cases:

Task Details

@github-actions

Copy link
Copy Markdown

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS FAIL 2d-rendering-in-3d,Morph,SwitchAnimation,event-first,geometry-renderer,planar-shadow,DragonBones,SpineAttach,dynamic-tiled-map,particle-culling,particle-rotation,capture_to_web,raycast-mesh&model,sprite-attribute-switch,bmfont,label-cacheMode-color,scroll-view-scroll-to-offset,pageView_free_horizontal,coordinate-ui-3d,motion-streak,visibility-changed
android PASS PASS FAIL 2d-rendering-in-3d,modelPriority,AnimationEvent,Morph,PartAnimation,SwitchAnimation,image-importer,load-atlas-texture,test-js-list,audioBuffer,dynamic-mesh,event-first,multiTouch,planar-shadow,shadowBias,localization,material,DragonBones,DragonBonesAttach,LoadSpine,SpineAttach,SpineBoy,dynamic-tiled-map,particle-color,particle-limit-velocity,particle-rotation,particle-velocity,rt-read-pixels,render-ui-to-spriteframe,cameraUseRenderTex,use-render-texture-asset,camera,hdr-ldr,raycast,CoreJsTest,terrain,tween-clone,tween-parallel,tween-removeself,tween-repeat-forever,tween-repeat,tween-show-hide,tween-stop,tween-then,tween,fill-sprite,filter,simple,sliced-sprite,sprite-grayscale,trimmed,bmfont,button-click,anim-widget,layout-size-changed,scroll-view-bounce-back,scroll-view-scroll-to-offset,rich-text-event,graphics-mask,mask-inverted,mask-migrate,mask-nesting,slider,progress,graphics-continuous-filling,graphics-draw-before-init,graphics,pageView_free_horizontal,coordinate-ui-3d,coordinate-ui-ui,motion-streak,particle-2d-color,particle-2d-position-type-change,opacity-multi-canvas,visibility-changed
wechatgame PASS PASS FAIL event-first,DragonBones,LoadSpine,scroll-view-scroll-to-offset

@dumganhar

Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

@github-actions

Copy link
Copy Markdown

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
ios PASS PASS PASS
mac PASS PASS FAIL mouse-event,touch-event

@github-actions

Copy link
Copy Markdown

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS PASS
android PASS PASS FAIL scroll-view-scroll-to-offset,coordinate-ui-ui
wechatgame PASS PASS PASS

@dumganhar

Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

@github-actions

Copy link
Copy Markdown

@dumganhar, Please check the result of run test cases:

Task Details

@github-actions

Copy link
Copy Markdown

@dumganhar, Please check the result of run test cases:

Task Details

@dumganhar
dumganhar merged commit be8fefa into cocos:v3.8.6 Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants