Skip to content

fixed #17593: [v3.8.6] 2D Particle crash on native platforms.#18070

Merged
minggo merged 3 commits intococos:v3.8.6from
dumganhar:386-fix-setSharedMaterial
Dec 23, 2024
Merged

fixed #17593: [v3.8.6] 2D Particle crash on native platforms.#18070
minggo merged 3 commits intococos:v3.8.6from
dumganhar:386-fix-setSharedMaterial

Conversation

@dumganhar
Copy link
Contributor

Batcher2D may use destroyed Material whose passes is empty, which will cause 'curdrawBatch->getPasses().at(0);' vector visit overflow.

Re: #17593

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Batcher2D may use destroyed Material whose passes is empty, which will cause 'curdrawBatch->getPasses().at(0);' vector visit overflow.
@dumganhar dumganhar requested a review from minggo December 21, 2024 07:42
@github-actions
Copy link

⚠️ Package size ⤴ 28 bytes, old: 5442241, new: 5442269

Interface Check Report

This pull request does not change any public interfaces !

@minggo minggo merged commit cd19bc2 into cocos:v3.8.6 Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants