Skip to content

[v3.8.6] Optimize code size for webgl-swapchain.ts & webgl2-swapchain.ts#18097

Merged
dumganhar merged 1 commit into
cocos:v3.8.6from
dumganhar:386-opt-size-gfx-swapchain
Dec 30, 2024
Merged

[v3.8.6] Optimize code size for webgl-swapchain.ts & webgl2-swapchain.ts#18097
dumganhar merged 1 commit into
cocos:v3.8.6from
dumganhar:386-opt-size-gfx-swapchain

Conversation

@dumganhar

Copy link
Copy Markdown
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions

Copy link
Copy Markdown

👍 Package size ⤵ -281 bytes, old: 5316212, new: 5315931

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar dumganhar requested review from minggo and star-e December 30, 2024 01:44
WebGL2DeviceManager.instance.capabilities.maxUniformBufferBindings,
WebGL2DeviceManager.instance.capabilities.maxVertexAttributes,
self.stateCache.initialize(
capabilities.maxTextureUnits,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid to invoke WebGL2DeviceManager.instance.capabilities many times which could not be mangled.

@dumganhar dumganhar merged commit 3dfbc53 into cocos:v3.8.6 Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants