Skip to content

[v3.8.6] Remove dead code in cocos/render-scene/config.ts#18114

Merged
minggo merged 1 commit into
cocos:v3.8.6from
dumganhar:386-remove-unused-render-scene-config
Jan 3, 2025
Merged

[v3.8.6] Remove dead code in cocos/render-scene/config.ts#18114
minggo merged 1 commit into
cocos:v3.8.6from
dumganhar:386-remove-unused-render-scene-config

Conversation

@dumganhar

@dumganhar dumganhar commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

It came from the first commit from : 0f23cba .

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar requested a review from minggo January 3, 2025 05:46
@minggo

minggo commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

It came from the first commit from : 0f23cba394c76c78eaa4f04cc1603d5b63a487ecl .

It is an invalid link.

@dumganhar

Copy link
Copy Markdown
Contributor Author

It is an invalid link.

Link updated.

@dumganhar dumganhar changed the title [v3.8.6] Remove dead code in cocos/render-scene-config.ts [v3.8.6] Remove dead code in cocos/render-scene/config.ts Jan 3, 2025
@github-actions

github-actions Bot commented Jan 3, 2025

Copy link
Copy Markdown

👍 Package size ⤵ -98 bytes, old: 5280433, new: 5280335

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -10425,9 +10425,8 @@
         export const deviceManager: DeviceManager;
     }
     export namespace renderer {
         export function createIA(device: gfx.Device, data: primitives.IGeometry): gfx.InputAssembler | null;
-        export const addStage: (name: any) => void;
         export interface IProgramInfo extends EffectAsset.IShaderInfo {
             effectName: string;
             defines: __private._cocos_render_scene_core_program_lib__IDefineRecord[];
             constantMacros: string;

@minggo minggo merged commit 33b0a50 into cocos:v3.8.6 Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants