Skip to content

Add box2d JSB codes to engine. #18152

Merged
dumganhar merged 32 commits into
cocos:v3.8.6from
tangkaikk:386box2dcpp
Feb 24, 2025
Merged

Add box2d JSB codes to engine. #18152
dumganhar merged 32 commits into
cocos:v3.8.6from
tangkaikk:386box2dcpp

Conversation

@tangkaikk

@tangkaikk tangkaikk commented Jan 10, 2025

Copy link
Copy Markdown
Contributor

Re: #18090 , All the infomation of comments and conversations is in the link of #18090.

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@tangkaikk tangkaikk mentioned this pull request Jan 10, 2025
6 tasks
@github-actions

github-actions Bot commented Jan 10, 2025

Copy link
Copy Markdown

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1001794 bytes 1001794 bytes ✅ 0 bytes
2D All (legacy pipeline) 2408779 bytes 2408779 bytes ✅ 0 bytes
2D All (new pipeline) 2498268 bytes 2498268 bytes ✅ 0 bytes
(2D + 3D) All 5380494 bytes 5412998 bytes ⚠️ +32504 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16603945 bytes 16636449 bytes ⚠️ +32504 bytes

Interface Check Report

This pull request does not change any public interfaces !

Comment thread cocos/physics-2d/box2d-jsb/joints/mouse-joint.ts Outdated
@minggo

minggo commented Jan 10, 2025

Copy link
Copy Markdown
Contributor

Please fix eslint error.

@tangkaikk

Copy link
Copy Markdown
Contributor Author

Please fix eslint error.

It has been fixed.

@minggo
minggo marked this pull request as draft January 22, 2025 06:47
@minggo

minggo commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

Can not merge this PR now. Should wait editor to finish corresponding work.

@dumganhar dumganhar closed this Feb 13, 2025
@dumganhar dumganhar reopened this Feb 13, 2025
@dumganhar
dumganhar marked this pull request as ready for review February 24, 2025 10:23
@dumganhar
dumganhar merged commit b08a406 into cocos:v3.8.6 Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants