fix #17890: preview scene in editor should also destroy object at the end of the frame rendering#18157
Merged
Merged
Conversation
…same, or engine components may refer invalid nodes
✅ Package size is not changedInterface Check ReportThis pull request does not change any public interfaces ! |
dumganhar
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#17890
As the modification shows,
setTimeout(CCObject._deferredDestroy);may destroy object at any time. It doesn't promise to destroy objects at the end of the frame. Then other engine components may refer the an invalid object. Which is problem.preview scene in editor will trigger the issue. So just destroy objects immediately only in editor mode. Editor doesn't use
requestAnimationFrameto drive engine loop, it control the loop itself.