[v3.8.6] Optimize size for particle-system.ts#18158
Merged
Merged
Conversation
👍 Package size ⤵ -1172 bytes, old: 5270176, new: 5269004Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -46637,9 +46637,9 @@
protected onEnable(): void;
protected onDisable(): void;
protected update(dt: number): void;
protected beforeRender(): void;
- protected _onVisibilityChange(val: any): void;
+ protected _onVisibilityChange(val: number): void;
/**
* @ignore
*/
get isPlaying(): boolean;
|
minggo
reviewed
Jan 13, 2025
| private declare _isStopped: boolean; | ||
| private declare _isEmitting: boolean; | ||
| private declare _needToRestart: boolean; | ||
| private declare _needRefresh: boolean; |
Contributor
Author
There was a problem hiding this comment.
It is assigned in constructor. If don't use declare, there will be two assignments in the generated js file.
constructor () {
...
this. _isStopped = void 0;
this. _isStopped = false;
...
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: