Skip to content

[v3.8.6] Optimize size for particle-system.ts#18158

Merged
minggo merged 3 commits into
cocos:v3.8.6from
dumganhar:386-opt-size-particle-1
Jan 13, 2025
Merged

[v3.8.6] Optimize size for particle-system.ts#18158
minggo merged 3 commits into
cocos:v3.8.6from
dumganhar:386-opt-size-particle-1

Conversation

@dumganhar

Copy link
Copy Markdown
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions

Copy link
Copy Markdown

👍 Package size ⤵ -1172 bytes, old: 5270176, new: 5269004

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -46637,9 +46637,9 @@
         protected onEnable(): void;
         protected onDisable(): void;
         protected update(dt: number): void;
         protected beforeRender(): void;
-        protected _onVisibilityChange(val: any): void;
+        protected _onVisibilityChange(val: number): void;
         /**
          * @ignore
          */
         get isPlaying(): boolean;

@dumganhar dumganhar changed the title [v3.8.6] [TEST] Optimize size for particle-system.ts [v3.8.6] Optimize size for particle-system.ts Jan 12, 2025
@dumganhar dumganhar requested a review from minggo January 12, 2025 15:56
private declare _isStopped: boolean;
private declare _isEmitting: boolean;
private declare _needToRestart: boolean;
private declare _needRefresh: boolean;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change them to delare?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is assigned in constructor. If don't use declare, there will be two assignments in the generated js file.

constructor () {
    ...
    this. _isStopped = void 0;
    this. _isStopped = false;
    ...
}

@minggo minggo merged commit d3050e1 into cocos:v3.8.6 Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants