Skip to content

[v3.8.6] Fix a mangleProperties issue which is caused by using as any in trail.ts.#18216

Merged
dumganhar merged 1 commit into
cocos:v3.8.6from
dumganhar:386-particle-tail-mangle-issue
Jan 20, 2025
Merged

[v3.8.6] Fix a mangleProperties issue which is caused by using as any in trail.ts.#18216
dumganhar merged 1 commit into
cocos:v3.8.6from
dumganhar:386-particle-tail-mangle-issue

Conversation

@dumganhar
Copy link
Copy Markdown
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar requested a review from minggo January 20, 2025 09:09
@github-actions
Copy link
Copy Markdown

⚠️ Package size ⤴ 9 bytes, old: 5233060, new: 5233069

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -68192,9 +68192,9 @@
             clear(): void;
             getModel(): _cocos_particle_models_particle_batch_model__default | null;
             protected _initModel(): void;
             updateTrailMaterial(): void;
-            getDefaultTrailMaterial(): null;
+            getDefaultTrailMaterial(): Material | null;
             abstract getParticleCount(): number;
             abstract getFreeParticle(): _cocos_particle_particle__Particle | null;
             abstract onMaterialModified(index: number, material: Material): void;
             abstract onRebuildPSO(index: number, material: Material): void;

@dumganhar
Copy link
Copy Markdown
Contributor Author

@minggo, I merged this PR since daily build depends on this.
If you get something to comment, I will update the code later.

@dumganhar dumganhar merged commit e652d6e into cocos:v3.8.6 Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant