Skip to content

Optimize code size again.#18260

Merged
minggo merged 3 commits into
cocos:v3.8.6from
dumganhar:386-opt-size-3
Feb 5, 2025
Merged

Optimize code size again.#18260
minggo merged 3 commits into
cocos:v3.8.6from
dumganhar:386-opt-size-3

Conversation

@dumganhar
Copy link
Copy Markdown
Contributor

Re: #18222

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 29, 2025

👍 Package size ⤵ -2016 bytes, old: 5225144, new: 5223128

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -23461,12 +23461,8 @@
             MAX = 255,
             DEFAULT = 128
         }
         /**
-         * @internal This method only used to init localDescriptorSetLayout.layouts[UBOSkinning.NAME]
-         */
-        export function localDescriptorSetLayout_ResizeMaxJoints(maxCount: number): void;
-        /**
          * @en Does the device support single-channeled half float texture? (for both color attachment and sampling)
          * @zh 当前设备是否支持单通道半浮点贴图?(颜色输出和采样)
          */
         export function supportsR16HalfFloatTexture(device: gfx.Device): boolean;

@dumganhar
Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

@dumganhar dumganhar requested a review from minggo February 5, 2025 05:59
@minggo minggo merged commit c08dbf5 into cocos:v3.8.6 Feb 5, 2025
cocos-robot pushed a commit to cocos-robot/engine that referenced this pull request Feb 5, 2025
minggo pushed a commit that referenced this pull request Feb 5, 2025
…18277)

Co-authored-by: cocos-robot <cocos-robot@cocos.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2025

@dumganhar, Please check the result of run test cases:

Task Details

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2025

@dumganhar, Please check the result of run test cases:

Task Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants