Optimize code size once more.#18267
Merged
Merged
Conversation
👍 Package size ⤵ -944 bytes, old: 5209319, new: 5208375Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -72227,9 +72227,9 @@
*/
export class _cocos_ui_view__ProportionalToFrame extends _cocos_ui_view__ContainerStrategy {
name: string;
constructor();
- apply(_view: any, designedResolution: any): void;
+ apply(_view: View, designedResolution: math.Size): void;
}
/**
* ContainerStrategy class is the root strategy class of container's scale strategy,
* it controls the behavior of how to scale the cc.game.container and cc.game.canvas object
@@ -72278,9 +72278,9 @@
}
export class _cocos_ui_view__ShowAll extends _cocos_ui_view__ContentStrategy {
name: string;
constructor();
- apply(_view: any, designedResolution: any): _cocos_ui_view__AdaptResult;
+ apply(_view: View, designedResolution: math.Size): _cocos_ui_view__AdaptResult;
}
export class _cocos_ui_view__NoBorder extends _cocos_ui_view__ContentStrategy {
name: string;
constructor();
@@ -72288,14 +72288,14 @@
}
export class _cocos_ui_view__FixedHeight extends _cocos_ui_view__ContentStrategy {
name: string;
constructor();
- apply(_view: any, designedResolution: any): _cocos_ui_view__AdaptResult;
+ apply(_view: View, designedResolution: math.Size): _cocos_ui_view__AdaptResult;
}
export class _cocos_ui_view__FixedWidth extends _cocos_ui_view__ContentStrategy {
name: string;
constructor();
- apply(_view: any, designedResolution: any): _cocos_ui_view__AdaptResult;
+ apply(_view: View, designedResolution: math.Size): _cocos_ui_view__AdaptResult;
}
/**
* @en
* Emit when canvas resize.
|
minggo
approved these changes
Feb 5, 2025
…86-opt-size-misc # Conflicts: # cocos/core/geometry/intersect.ts
Contributor
Author
|
@cocos-robot run test cases |
1 similar comment
Contributor
Author
|
@cocos-robot run test cases |
|
@dumganhar, Please check the result of
Task Details
|
|
@dumganhar, Please check the result of
Task Details |
|
@dumganhar, Please check the result of
Task Details
|
|
@dumganhar, Please check the result of
Task Details |
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #18222
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: