Skip to content

Optimize code size once more.#18267

Merged
dumganhar merged 5 commits into
cocos:v3.8.6from
dumganhar:386-opt-size-misc
Feb 6, 2025
Merged

Optimize code size once more.#18267
dumganhar merged 5 commits into
cocos:v3.8.6from
dumganhar:386-opt-size-misc

Conversation

@dumganhar

Copy link
Copy Markdown
Contributor

Re: #18222

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions

github-actions Bot commented Jan 30, 2025

Copy link
Copy Markdown

👍 Package size ⤵ -944 bytes, old: 5209319, new: 5208375

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -72227,9 +72227,9 @@
          */
         export class _cocos_ui_view__ProportionalToFrame extends _cocos_ui_view__ContainerStrategy {
             name: string;
             constructor();
-            apply(_view: any, designedResolution: any): void;
+            apply(_view: View, designedResolution: math.Size): void;
         }
         /**
          * ContainerStrategy class is the root strategy class of container's scale strategy,
          * it controls the behavior of how to scale the cc.game.container and cc.game.canvas object
@@ -72278,9 +72278,9 @@
         }
         export class _cocos_ui_view__ShowAll extends _cocos_ui_view__ContentStrategy {
             name: string;
             constructor();
-            apply(_view: any, designedResolution: any): _cocos_ui_view__AdaptResult;
+            apply(_view: View, designedResolution: math.Size): _cocos_ui_view__AdaptResult;
         }
         export class _cocos_ui_view__NoBorder extends _cocos_ui_view__ContentStrategy {
             name: string;
             constructor();
@@ -72288,14 +72288,14 @@
         }
         export class _cocos_ui_view__FixedHeight extends _cocos_ui_view__ContentStrategy {
             name: string;
             constructor();
-            apply(_view: any, designedResolution: any): _cocos_ui_view__AdaptResult;
+            apply(_view: View, designedResolution: math.Size): _cocos_ui_view__AdaptResult;
         }
         export class _cocos_ui_view__FixedWidth extends _cocos_ui_view__ContentStrategy {
             name: string;
             constructor();
-            apply(_view: any, designedResolution: any): _cocos_ui_view__AdaptResult;
+            apply(_view: View, designedResolution: math.Size): _cocos_ui_view__AdaptResult;
         }
         /**
          * @en
          * Emit when canvas resize.

@dumganhar
dumganhar requested a review from minggo February 5, 2025 06:03
…86-opt-size-misc

# Conflicts:
#	cocos/core/geometry/intersect.ts
@dumganhar

Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

1 similar comment
@dumganhar

Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

@github-actions

github-actions Bot commented Feb 6, 2025

Copy link
Copy Markdown

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL
ios PASS PASS PASS
mac PASS PASS PASS

@github-actions

github-actions Bot commented Feb 6, 2025

Copy link
Copy Markdown

@dumganhar, Please check the result of run test cases:

Task Details

@dumganhar
dumganhar merged commit e6273fc into cocos:v3.8.6 Feb 6, 2025
@github-actions

github-actions Bot commented Feb 6, 2025

Copy link
Copy Markdown

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL
ios PASS PASS PASS
mac PASS PASS PASS

@github-actions

github-actions Bot commented Feb 6, 2025

Copy link
Copy Markdown

@dumganhar, Please check the result of run test cases:

Task Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants