Skip to content

Fix deprecated String.substr, use String.substring instead.#18272

Merged
minggo merged 1 commit into
cocos:v3.8.6from
dumganhar:386-fix-substr
Feb 5, 2025
Merged

Fix deprecated String.substr, use String.substring instead.#18272
minggo merged 1 commit into
cocos:v3.8.6from
dumganhar:386-fix-substr

Conversation

@dumganhar
Copy link
Copy Markdown
Contributor

@dumganhar dumganhar commented Feb 1, 2025

The signature '(from: number, length?: number | undefined): string' of 'labelString.substr' is deprecated.ts(6387)
lib.es5.d.ts(522, 8): The declaration was marked as deprecated here.
(method) String.substr(from: number, length?: number): string
Gets a substring beginning at the specified location and having the specified length.

@deprecated — A legacy feature for browser compatibility

@param from — The starting position of the desired substring. The index of the first character in the string is zero.

@param length — The number of characters to include in the returned substring.

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 1, 2025

⚠️ Package size ⤴ 36 bytes, old: 5225108, new: 5225144

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar dumganhar requested a review from minggo February 5, 2025 05:43
@minggo minggo merged commit aca53d2 into cocos:v3.8.6 Feb 5, 2025
@dumganhar
Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2025

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL graphics-line-join
ios PASS PASS PASS
mac PASS PASS PASS

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2025

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS PASS
android PASS PASS PASS
wechatgame PASS FAIL FAIL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants