Skip to content

Fix wrong position and rectangle border of gizmo in editor.#18280

Merged
minggo merged 4 commits into
cocos:v3.8.6from
dumganhar:386-fix-skew-gizmo
Feb 6, 2025
Merged

Fix wrong position and rectangle border of gizmo in editor.#18280
minggo merged 4 commits into
cocos:v3.8.6from
dumganhar:386-fix-skew-gizmo

Conversation

@dumganhar

Copy link
Copy Markdown
Contributor

Re: #18212

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar
dumganhar requested a review from minggo February 6, 2025 08:05
@github-actions

github-actions Bot commented Feb 6, 2025

Copy link
Copy Markdown

⚠️ Package size ⤴ 84 bytes, old: 5209489, new: 5209573

Interface Check Report

This pull request does not change any public interfaces !

* @param out The node's original world matrix without skew.
* @return true if the node or its parent has skew components, otherwise returns false.
*/
export function findSkewAndGetOriginalWorldMatrix (node: Node | null, out: Mat4): boolean {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funcitons in ui-skew-utils are all internal.

@minggo
minggo merged commit 78b61b2 into cocos:v3.8.6 Feb 6, 2025
dumganhar added a commit to dumganhar/cocos-engine that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants