remove deferred reflection shaders#18281
Merged
Merged
Conversation
GengineJS
approved these changes
Feb 6, 2025
👍 Package size ⤵ -1108 bytes, old: 5208459, new: 5207351Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -11820,10 +11820,8 @@
protected _priority: pipeline.RenderPriority;
protected _inputAssembler: gfx.InputAssembler | null;
protected _descriptorSet: gfx.DescriptorSet | null;
protected _worldBoundDescriptorSet: gfx.DescriptorSet | null;
- protected _reflectionTex: gfx.Texture | null;
- protected _reflectionSampler: gfx.Sampler | null;
protected _instancedAttributeBlock: IInstancedAttributeBlock;
protected _instancedWorldMatrixIndex: number;
protected _instancedSHIndex: number;
protected _useReflectionProbeType: number;
@@ -23562,15 +23560,13 @@
SAMPLER_MORPH_NORMAL = 9,
SAMPLER_MORPH_TANGENT = 10,
SAMPLER_LIGHTMAP = 11,
SAMPLER_SPRITE = 12,
- SAMPLER_REFLECTION = 13,
- STORAGE_REFLECTION = 14,
- SAMPLER_REFLECTION_PROBE_CUBE = 15,
- SAMPLER_REFLECTION_PROBE_PLANAR = 16,
- SAMPLER_REFLECTION_PROBE_DATA_MAP = 17,
- SAMPLER_REFLECTION_PROBE_BLEND_CUBE = 18,
- COUNT = 19
+ SAMPLER_REFLECTION_PROBE_CUBE = 13,
+ SAMPLER_REFLECTION_PROBE_PLANAR = 14,
+ SAMPLER_REFLECTION_PROBE_DATA_MAP = 15,
+ SAMPLER_REFLECTION_PROBE_BLEND_CUBE = 16,
+ COUNT = 17
}
export const bindingMappingInfo: gfx.BindingMappingInfo;
export enum UBOGlobalEnum {
TIME_OFFSET = 0,
@@ -23922,10 +23918,8 @@
export const UNIFORM_NORMAL_MORPH_TEXTURE_BINDING = ModelLocalBindings.SAMPLER_MORPH_NORMAL;
export const UNIFORM_TANGENT_MORPH_TEXTURE_BINDING = ModelLocalBindings.SAMPLER_MORPH_TANGENT;
export const UNIFORM_LIGHTMAP_TEXTURE_BINDING = ModelLocalBindings.SAMPLER_LIGHTMAP;
export const UNIFORM_SPRITE_TEXTURE_BINDING = ModelLocalBindings.SAMPLER_SPRITE;
- export const UNIFORM_REFLECTION_TEXTURE_BINDING = ModelLocalBindings.SAMPLER_REFLECTION;
- export const UNIFORM_REFLECTION_STORAGE_BINDING = ModelLocalBindings.STORAGE_REFLECTION;
export const UNIFORM_REFLECTION_PROBE_CUBEMAP_BINDING = ModelLocalBindings.SAMPLER_REFLECTION_PROBE_CUBE;
export const UNIFORM_REFLECTION_PROBE_TEXTURE_BINDING = ModelLocalBindings.SAMPLER_REFLECTION_PROBE_PLANAR;
export const UNIFORM_REFLECTION_PROBE_DATA_MAP_BINDING = ModelLocalBindings.SAMPLER_REFLECTION_PROBE_DATA_MAP;
export const UNIFORM_REFLECTION_PROBE_BLEND_CUBEMAP_BINDING = ModelLocalBindings.SAMPLER_REFLECTION_PROBE_BLEND_CUBE;
|
Contributor
Author
|
@cocos-robot run test cases |
|
@star-e, Please check the result of
Task Details
|
|
@star-e, Please check the result of
Task Details
|
Contributor
Author
|
@cocos-robot run test cases |
|
@star-e, Please check the result of
Task Details
|
|
@star-e, Please check the result of
Task Details
|
Contributor
Author
|
@cocos-robot run test cases |
Contributor
Author
|
@cocos-robot run test cases custom |
|
@star-e, Please check the result of
Task Details
|
|
@star-e, Please check the result of
Task Details
|
Contributor
|
minggo
approved these changes
Feb 7, 2025
Contributor
Author
The reason is the editor might not have been updated. After the pr is merged and editor is updated, the test error will be gone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reduce texture count for WebGPU, remove unused reflectionTex in deferred pipeline.
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: