Skip to content

Fix the bug that ParticleSystem2D re-active causes particle could not be shown.#18295

Merged
minggo merged 3 commits into
cocos:v3.8.6from
dumganhar:386-fix-particle-system-2d-active
Feb 8, 2025
Merged

Fix the bug that ParticleSystem2D re-active causes particle could not be shown.#18295
minggo merged 3 commits into
cocos:v3.8.6from
dumganhar:386-fix-particle-system-2d-active

Conversation

@dumganhar

@dumganhar dumganhar commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

Re: This issue is caused by the Pull Request #18052
I have described the reason in that PR.

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar requested review from GengineJS and minggo February 7, 2025 13:26
@github-actions

github-actions Bot commented Feb 7, 2025

Copy link
Copy Markdown

⚠️ Package size ⤴ 182 bytes, old: 5193082, new: 5193264

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -46230,8 +46230,9 @@
         onDestroy(): void;
         onFocusInEditor(): void;
         onLostFocusInEditor(): void;
         __preload(): void;
+        destroyRenderData(): void;
         protected _flushAssembler(): void;
         protected lateUpdate(dt: number): void;
         /**
          * @en Add a particle to the emitter.
@@ -68240,9 +68241,9 @@
             particles: _cocos_particle_2d_particle_simulator_2d__Particle[];
             active: boolean;
             uvFilled: number;
             finished: boolean;
-            renderData: MeshRenderData;
+            renderData: MeshRenderData | null;
             constructor(system: any);
             stop(): void;
             reset(): void;
             emitParticle(pos: any): void;

Comment thread cocos/particle-2d/particle-system-2d.ts Outdated
Comment thread cocos/particle-2d/particle-system-2d.ts
@dumganhar dumganhar requested a review from minggo February 8, 2025 03:29
@minggo minggo merged commit f94a17c into cocos:v3.8.6 Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants