Skip to content

Export memory-pools only for NATIVE since it's used for sharing memory between native and js#18296

Merged
minggo merged 1 commit into
cocos:v3.8.6from
dumganhar:386-dont-export-memory-pools
Feb 8, 2025
Merged

Export memory-pools only for NATIVE since it's used for sharing memory between native and js#18296
minggo merged 1 commit into
cocos:v3.8.6from
dumganhar:386-dont-export-memory-pools

Conversation

@dumganhar

Copy link
Copy Markdown
Contributor

Re: #18222

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions

github-actions Bot commented Feb 7, 2025

Copy link
Copy Markdown

👍 Package size ⤵ -2524 bytes, old: 5195606, new: 5193082

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar

Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

@dumganhar dumganhar requested a review from minggo February 7, 2025 14:36
@dumganhar

Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

@minggo minggo merged commit 9c6f362 into cocos:v3.8.6 Feb 8, 2025
@github-actions

github-actions Bot commented Feb 8, 2025

Copy link
Copy Markdown

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL
ios PASS PASS FAIL reflection-probe
mac PASS PASS FAIL reflection-probe

@github-actions

github-actions Bot commented Feb 8, 2025

Copy link
Copy Markdown

@dumganhar, Please check the result of run test cases:

Task Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants