Skip to content

Fix the type of Billboard.texture#18297

Merged
dumganhar merged 1 commit into
cocos:v3.8.6from
dumganhar:386-billboard-set-texture-type
Feb 8, 2025
Merged

Fix the type of Billboard.texture#18297
dumganhar merged 1 commit into
cocos:v3.8.6from
dumganhar:386-billboard-set-texture-type

Conversation

@dumganhar

Copy link
Copy Markdown
Contributor

Reported at https://forum.cocos.org/t/topic/165212/73?u=dumganhar

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar
dumganhar requested a review from minggo February 8, 2025 02:13
@github-actions

github-actions Bot commented Feb 8, 2025

Copy link
Copy Markdown

👍 Package size ⤵ -10 bytes, old: 5193082, new: 5193072

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -46390,10 +46390,10 @@
     export class Billboard extends Component {
         /**
          * @zh Billboard纹理。
          */
-        get texture(): null;
-        set texture(val: null);
+        get texture(): Texture2D | null;
+        set texture(val: Texture2D | null);
         /**
          * @zh 高度。
          */
         get height(): number;

@dumganhar
dumganhar merged commit 9aa6873 into cocos:v3.8.6 Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants