Skip to content

fix buffer out of range#18305

Merged
star-e merged 1 commit intococos:v3.8.6from
star-e:v3.8.6-uniform
Feb 10, 2025
Merged

fix buffer out of range#18305
star-e merged 1 commit intococos:v3.8.6from
star-e:v3.8.6-uniform

Conversation

@star-e
Copy link
Copy Markdown
Contributor

@star-e star-e commented Feb 10, 2025

https://github.com/cocos/issues-of-car-team/issues/23

Fix buffer range out of bound. The size of the last uniform block must be aligned to 16 as in _bufferViewInfo.range.
Otherwise, the buffer validator will assert.

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@star-e star-e requested a review from minggo February 10, 2025 05:26
@star-e
Copy link
Copy Markdown
Contributor Author

star-e commented Feb 10, 2025

@cocos-robot run test cases

@github-actions
Copy link
Copy Markdown

⚠️ Package size ⤴ 17 bytes, old: 5192584, new: 5192601

Interface Check Report

This pull request does not change any public interfaces !

@github-actions
Copy link
Copy Markdown

@star-e, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL graphics-line-join
ios PASS PASS FAIL reflection-probe
mac PASS PASS FAIL reflection-probe

@github-actions
Copy link
Copy Markdown

@star-e, Please check the result of run test cases:

Task Details

@star-e star-e merged commit 2231a83 into cocos:v3.8.6 Feb 10, 2025
@star-e star-e deleted the v3.8.6-uniform branch February 10, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants