Skip to content

Add support for rotational skew. - #18307

Merged
dumganhar merged 3 commits into
cocos:v3.8.6from
dumganhar:386-rotational-skew
Feb 11, 2025
Merged

Add support for rotational skew.#18307
dumganhar merged 3 commits into
cocos:v3.8.6from
dumganhar:386-rotational-skew

Conversation

@dumganhar

@dumganhar dumganhar commented Feb 10, 2025

Copy link
Copy Markdown
Contributor

The feature was requested from : https://forum.cocos.org/t/topic/162327/54

Rotational Skew is also supported in Cocos2D-X.
See https://github.com/cocos2d/cocos2d-x/blob/v4/cocos/2d/CCNode.h#L638

Re: #17852

  • Add a Rotational checkbox

WeChatff4c32ff223086c4fceef3c791e75a5f

  • The difference of standard skew and rotational skew:
skew-compare.mp4

The test assets:
TestAssets.zip

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar
dumganhar requested a review from minggo February 10, 2025 07:22
@github-actions

github-actions Bot commented Feb 10, 2025

Copy link
Copy Markdown

⚠️ Package size ⤴ 520 bytes, old: 5192601, new: 5193121

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -55782,8 +55782,10 @@
         onComplete?: (target?: T) => void;
     }
     export class UISkew extends Component {
         constructor();
+        get rotational(): boolean;
+        set rotational(value: boolean);
         protected __preload(): void;
         protected onEnable(): void;
         protected onDisable(): void;
         protected onDestroy(): void;

@dumganhar
dumganhar marked this pull request as draft February 10, 2025 07:42
@dumganhar

Copy link
Copy Markdown
Contributor Author

Native code also needs to be updated.
I will update it soon.

@dumganhar
dumganhar marked this pull request as ready for review February 10, 2025 08:50
@dumganhar

Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

@github-actions

Copy link
Copy Markdown

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
ios PASS PASS FAIL reflection-probe
mac PASS PASS FAIL reflection-probe

@github-actions

Copy link
Copy Markdown

@dumganhar, Please check the result of run test cases:

Task Details

@dumganhar
dumganhar merged commit b7cc23d into cocos:v3.8.6 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants