Skip to content

Fix spine's crash due to destroy called after animation play complete. - #18342

Merged
dumganhar merged 1 commit into
cocos:v3.8.6from
bofeng-song:fix_spine
Feb 17, 2025
Merged

Fix spine's crash due to destroy called after animation play complete.#18342
dumganhar merged 1 commit into
cocos:v3.8.6from
bofeng-song:fix_spine

Conversation

@bofeng-song

Copy link
Copy Markdown
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@bofeng-song
bofeng-song requested a review from minggo February 17, 2025 10:05
}

void MiddlewareManager::render(float dt) {
for (auto &iter: _operateCacheMap) {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node destroy maybe called while trigger update, but skeleton still exist at _updateList, thus skeletonAnimation will visit a destroyed object.

@dumganhar

Copy link
Copy Markdown
Contributor

@cocos-robot run test cases

@github-actions

Copy link
Copy Markdown

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1001884 bytes 1001884 bytes ✅ 0 bytes
2D All (legacy pipeline) 2408866 bytes 2408866 bytes ✅ 0 bytes
2D All (new pipeline) 2498355 bytes 2498355 bytes ✅ 0 bytes
(2D + 3D) All 5381005 bytes 5381005 bytes ✅ 0 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16604469 bytes 16604469 bytes ✅ 0 bytes

Interface Check Report

This pull request does not change any public interfaces !

@github-actions

Copy link
Copy Markdown

@bofeng-song, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL
ios PASS PASS FAIL
mac PASS PASS FAIL reflection-probe

@github-actions

Copy link
Copy Markdown

@bofeng-song, Please check the result of run test cases:

Task Details

@dumganhar

Copy link
Copy Markdown
Contributor

Merge for daily build. Probably we need to refactor the code later.

@dumganhar
dumganhar merged commit 41d8447 into cocos:v3.8.6 Feb 17, 2025
bofeng-song added a commit to bofeng-song/engine that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants