Fix spine's crash due to destroy called after animation play complete. - #18342
Merged
Conversation
bofeng-song
commented
Feb 17, 2025
| } | ||
|
|
||
| void MiddlewareManager::render(float dt) { | ||
| for (auto &iter: _operateCacheMap) { |
Contributor
Author
There was a problem hiding this comment.
Node destroy maybe called while trigger update, but skeleton still exist at _updateList, thus skeletonAnimation will visit a destroyed object.
Contributor
|
@cocos-robot run test cases |
Code Size Check Report
Interface Check ReportThis pull request does not change any public interfaces ! |
|
@bofeng-song, Please check the result of
Task Details
|
|
@bofeng-song, Please check the result of
Task Details |
Contributor
|
Merge for daily build. Probably we need to refactor the code later. |
bofeng-song
added a commit
to bofeng-song/engine
that referenced
this pull request
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: