Skip to content

Fix some memory leaks of JSVM backend for HarmonyOS next platforms - #18404

Merged
dumganhar merged 4 commits into
cocos:v3.8.6from
dumganhar:386-jsvm-tweaks
Mar 4, 2025
Merged

Fix some memory leaks of JSVM backend for HarmonyOS next platforms#18404
dumganhar merged 4 commits into
cocos:v3.8.6from
dumganhar:386-jsvm-tweaks

Conversation

@dumganhar

Copy link
Copy Markdown
Contributor

Including:

  • Fix a memory leak of JSVM_Ref for se::Class::_constructor.
  • Fix memory leaks of se::Object instances associated with Spine objects.
  • JSVM code cache is not supported now, doesn't need to create code cache since it's not consumed.

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar
dumganhar requested a review from qiuguohua March 4, 2025 07:37
@github-actions

github-actions Bot commented Mar 4, 2025

Copy link
Copy Markdown

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1001919 bytes 1001919 bytes ✅ 0 bytes
2D All (legacy pipeline) 2408921 bytes 2408921 bytes ✅ 0 bytes
2D All (new pipeline) 2496150 bytes 2496150 bytes ✅ 0 bytes
(2D + 3D) All 5412404 bytes 5412404 bytes ✅ 0 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16927340 bytes 16927340 bytes ✅ 0 bytes

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar
dumganhar merged commit 9aad4d4 into cocos:v3.8.6 Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants