Skip to content

Print a error info to console while parse unsupported spine version#18414

Merged
dumganhar merged 4 commits into
cocos:v3.8.6from
bofeng-song:spine_fix
Mar 7, 2025
Merged

Print a error info to console while parse unsupported spine version#18414
dumganhar merged 4 commits into
cocos:v3.8.6from
bofeng-song:spine_fix

Conversation

@bofeng-song

Copy link
Copy Markdown
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@bofeng-song bofeng-song requested a review from dumganhar March 6, 2025 05:47
@github-actions

github-actions Bot commented Mar 6, 2025

Copy link
Copy Markdown

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1001919 bytes 1001919 bytes ✅ 0 bytes
2D All (legacy pipeline) 2409295 bytes 2409507 bytes ⚠️ +212 bytes
2D All (new pipeline) 2496524 bytes 2496736 bytes ⚠️ +212 bytes
(2D + 3D) All 5413059 bytes 5413271 bytes ⚠️ +212 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16920733 bytes 16920922 bytes ⚠️ +189 bytes

Interface Check Report

This pull request does not change any public interfaces !

namespace {
static const int LOG_LEVEL_ERROR = 3;
static const int LOG_LEVEL_WARN = 2;
static const int LOG_LEVEL_INFO = 1;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't need static keyword in anonymous namespace.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment thread native/cocos/editor-support/spine/3.8/spine/SkeletonJson.cpp Outdated
@dumganhar dumganhar merged commit 80f0551 into cocos:v3.8.6 Mar 7, 2025
@bofeng-song bofeng-song deleted the spine_fix branch May 19, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants