Skip to content

Fix memory leak for spine::Vector::setSize - #18431

Merged
dumganhar merged 6 commits into
cocos:v3.8.6from
dumganhar:386-fix-spine-wasm-Vector-leak
Mar 10, 2025
Merged

Fix memory leak for spine::Vector::setSize#18431
dumganhar merged 6 commits into
cocos:v3.8.6from
dumganhar:386-fix-spine-wasm-Vector-leak

Conversation

@dumganhar

Copy link
Copy Markdown
Contributor

Reported at https://forum.cocos.org/t/topic/165212/319

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar
dumganhar requested a review from bofeng-song March 9, 2025 11:54
@github-actions

github-actions Bot commented Mar 9, 2025

Copy link
Copy Markdown

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1001919 bytes 1001919 bytes ✅ 0 bytes
2D All (legacy pipeline) 2662574 bytes 2662839 bytes ⚠️ +265 bytes
2D All (new pipeline) 2749803 bytes 2750068 bytes ⚠️ +265 bytes
(2D + 3D) All 10003103 bytes 10003368 bytes ⚠️ +265 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16915013 bytes 16916185 bytes ⚠️ +1172 bytes

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar
dumganhar merged commit 15a487c into cocos:v3.8.6 Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants