Skip to content

Fix the issue of inconsistent attachment sizes - #18455

Merged
star-e merged 3 commits into
cocos:v3.8.6from
GengineJS:v3.8.6-0311
Mar 13, 2025
Merged

Fix the issue of inconsistent attachment sizes#18455
star-e merged 3 commits into
cocos:v3.8.6from
GengineJS:v3.8.6-0311

Conversation

@GengineJS

Copy link
Copy Markdown
Contributor

No description provided.

@GengineJS
GengineJS requested review from dumganhar and star-e March 13, 2025 05:54
@github-actions

github-actions Bot commented Mar 13, 2025

Copy link
Copy Markdown

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1001924 bytes 1001924 bytes ✅ 0 bytes
2D All (legacy pipeline) 2662943 bytes 2662943 bytes ✅ 0 bytes
2D All (new pipeline) 2750172 bytes 2750172 bytes ✅ 0 bytes
(2D + 3D) All 10003545 bytes 10003554 bytes ⚠️ +9 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16915815 bytes 16915824 bytes ⚠️ +9 bytes

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -45124,9 +45124,9 @@
         set gpuConfig(config: __private.__types_webGPU__GPUCanvasConfiguration);
         get gpuConfig(): __private.__types_webGPU__GPUCanvasConfiguration;
         protected initFormatFeatures(exts: __private.__types_webGPU__GPUSupportedFeatures): void;
         getDefaultDescResources(entry: __private.__types_webGPU__GPUBindGroupLayoutEntry, resourceInfo: __private._cocos_gfx_webgpu_webgpu_gpu_objects__IWebGPUGPUBuffer | __private._cocos_gfx_webgpu_webgpu_gpu_objects__IWebGPUTexture | __private._cocos_gfx_webgpu_webgpu_gpu_objects__IWebGPUGPUSampler): __private._cocos_gfx_webgpu_webgpu_buffer__WebGPUBuffer | __private._cocos_gfx_webgpu_webgpu_texture__WebGPUTexture | __private._cocos_gfx_webgpu_webgpu_sampler__WebGPUSampler | undefined;
-        get FloatFilterable(): boolean;
+        get floatFilterable(): boolean;
         destroy(): void;
         resize(width: number, height: number): void;
         acquire(): void;
         get nativeDevice(): GPUDevice | null | undefined;

Comment thread cocos/gfx/webgpu/define.ts Outdated
SampleCount.X1,
1,
);
return texInfo;

@dumganhar dumganhar Mar 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to new TextureInfo each time invoke getDefaultDSInfo? Could we cache the default value?

@GengineJS
GengineJS requested a review from dumganhar March 13, 2025 08:12
@star-e

star-e commented Mar 13, 2025

Copy link
Copy Markdown
Contributor

@cocos-robot run test cases

@star-e
star-e merged commit f02e943 into cocos:v3.8.6 Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants