Skip to content

Fix the crash caused when getResult throws an exception.#18459

Merged
dumganhar merged 1 commit intococos:v3.8.6from
qiuguohua:v3.8.6_fix_achievements_crash
Mar 13, 2025
Merged

Fix the crash caused when getResult throws an exception.#18459
dumganhar merged 1 commit intococos:v3.8.6from
qiuguohua:v3.8.6_fix_achievements_crash

Conversation

@qiuguohua
Copy link
Copy Markdown
Contributor

Re: #

https://github.com/cocos/3d-tasks/issues/18870


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@qiuguohua qiuguohua requested a review from dumganhar March 13, 2025 13:50
@github-actions
Copy link
Copy Markdown

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1001924 bytes 1001924 bytes ✅ 0 bytes
2D All (legacy pipeline) 2662943 bytes 2662943 bytes ✅ 0 bytes
2D All (new pipeline) 2750172 bytes 2750172 bytes ✅ 0 bytes
(2D + 3D) All 10003554 bytes 10003554 bytes ✅ 0 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16915826 bytes 16915826 bytes ✅ 0 bytes

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar dumganhar merged commit 84e22ab into cocos:v3.8.6 Mar 13, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants