V3.8.7 add global uniform interface - #18540
Merged
Merged
Conversation
Code Size Check Report
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -36636,9 +36636,9 @@
* 这些资源一般是可读写的资源。
* 资源在注册后,不能更改驻留属性。
* 用户可以每帧构建一个render graph,然后交由管线执行。
*/
- export interface BasicPipeline extends __private._cocos_rendering_custom_pipeline__PipelineRuntime {
+ export interface BasicPipeline extends __private._cocos_rendering_custom_pipeline__PipelineRuntime, Setter {
readonly type: PipelineType;
readonly capabilities: PipelineCapabilities;
/**
* @en Enable cpu culling of objects affected by the light. Enabled by default.
|
dumganhar
reviewed
Apr 1, 2025
| void setQuaternion(const ccstd::string &name, const Quaternion &quat) override; | ||
| void setColor(const ccstd::string &name, const gfx::Color &color) override; | ||
| void setVec4(const ccstd::string &name, const Vec4 &vec) override; | ||
| void setVec2(const ccstd::string &name, const Vec2 &vec) override; |
Contributor
Author
There was a problem hiding this comment.
Doesn't need
setVec3?
Vec3 is very error prone for buffer layout alignment calculation. We suggest using Vec4 instead.
GengineJS
approved these changes
Apr 1, 2025
dumganhar
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V3.8.7 add global uniform interface
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: