Skip to content

V3.8.7 add global uniform interface - #18540

Merged
star-e merged 10 commits into
cocos:v3.8.7from
star-e:v3.8.7-pipeline2
Apr 1, 2025
Merged

V3.8.7 add global uniform interface#18540
star-e merged 10 commits into
cocos:v3.8.7from
star-e:v3.8.7-pipeline2

Conversation

@star-e

@star-e star-e commented Mar 31, 2025

Copy link
Copy Markdown
Contributor

V3.8.7 add global uniform interface

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@star-e star-e changed the title V3.8.7 pipeline2 V3.8.7 add global uniform interface Mar 31, 2025
@star-e
star-e requested a review from GengineJS March 31, 2025 05:18
@github-actions

Copy link
Copy Markdown

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1002411 bytes 1002411 bytes ✅ 0 bytes
2D All (legacy pipeline) 2663845 bytes 2663845 bytes ✅ 0 bytes
2D All (new pipeline) 2751265 bytes 2752053 bytes ⚠️ +788 bytes
(2D + 3D) All 10004545 bytes 10005333 bytes ⚠️ +788 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16917045 bytes 16917833 bytes ⚠️ +788 bytes

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -36636,9 +36636,9 @@
          * 这些资源一般是可读写的资源。
          * 资源在注册后,不能更改驻留属性。
          * 用户可以每帧构建一个render graph,然后交由管线执行。
          */
-        export interface BasicPipeline extends __private._cocos_rendering_custom_pipeline__PipelineRuntime {
+        export interface BasicPipeline extends __private._cocos_rendering_custom_pipeline__PipelineRuntime, Setter {
             readonly type: PipelineType;
             readonly capabilities: PipelineCapabilities;
             /**
              * @en Enable cpu culling of objects affected by the light. Enabled by default.

@star-e
star-e requested a review from dumganhar April 1, 2025 08:12
void setQuaternion(const ccstd::string &name, const Quaternion &quat) override;
void setColor(const ccstd::string &name, const gfx::Color &color) override;
void setVec4(const ccstd::string &name, const Vec4 &vec) override;
void setVec2(const ccstd::string &name, const Vec2 &vec) override;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't need setVec3?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't need setVec3?

Vec3 is very error prone for buffer layout alignment calculation. We suggest using Vec4 instead.

@star-e
star-e merged commit 2466eea into cocos:v3.8.7 Apr 1, 2025
@star-e
star-e deleted the v3.8.7-pipeline2 branch April 1, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants