improve VideoPlayer fullscreen for 2d-tasks/issues/1562 #4845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix ArmatureDisplay property error. * modify the translation
|
不进 2.1.2，放到 2.2 |
pandamicro
reviewed
Jul 9, 2019
| @@ -48,6 +48,7 @@ let VideoPlayerImpl = cc.Class({ | |||
| this._video = null; | |||
| this._url = ''; | |||
|
|
|||
| this._preFullScreenEnabled = undefined; | |||
There was a problem hiding this comment.
这个类型应该是 boolean，为什么要赋值为 undefined
| } | ||
| else if (cc.screen.fullScreen()) { | ||
| cc.screen.exitFullScreen(video); | ||
| if (self._preFullScreenEnabled !== undefined) { |
There was a problem hiding this comment.
如果是为了延迟处理，按理说只需要记录一个 waitingFullscreen 就好了
There was a problem hiding this comment.
但是这样如果记录了 waitingFullscreen，如何知道是 fullscreen 还是 exitfullscreen ？
还是需要记录 enable 的状态的
There was a problem hiding this comment.
loadedmetadata 之前怎么可能已经全屏了呢？
pandamicro
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Re: cocos/2d-tasks#1562
Changes: