Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spine or dragonbones cache bug #5588

Conversation

sunnylanwanjun
Copy link
Contributor

@sunnylanwanjun sunnylanwanjun commented Oct 23, 2019

forum: https://forum.cocos.com/t/2-2-0-spine-bug/84833
修复手动先释放资源,再移除节点造成纹理丢失的问题。

@@ -42,6 +42,7 @@ let _x, _y;
//Cache all frames in an animation
let AnimationCache = cc.Class({
ctor () {
this._inited = false;
Copy link
Contributor

@holycanvas holycanvas Oct 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inited 这个词比较怪,init 已经是缩写了,再加 ed 就是我们造的词了,要不用还是用全称吧

Copy link
Contributor

@holycanvas holycanvas Oct 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

算了,引擎其他地方也这么用了,那就统一用 inited 吧

@holycanvas holycanvas merged commit 208cd95 into cocos:v2.2.1-release Oct 25, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants