fix tiledmap object texture render error #5633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jareguo
reviewed
Oct 28, 2019
| @@ -224,7 +224,8 @@ let TiledObjectGroup = cc.Class({ | |||
| sp = imgNode.addComponent(cc.Sprite); | |||
| } | |||
| sp.spriteFrame = new cc.SpriteFrame(); | |||
| sp.spriteFrame.setTexture(grid.tileset.sourceImage, grid); | |||
| let rect = cc.rect(grid.x, grid.y, grid.width, grid.height); | |||
| sp.spriteFrame.setTexture(grid.tileset.sourceImage, rect); | |||
holycanvas
reviewed
Oct 28, 2019
holycanvas
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
修复object group纹理坐标不正确的问题。
修复在同一帧插入删除再插入用户节点，会报组件已存在的问题。（因为组件在下一帧才会从node中移除，这里调用了内部的_removeComponent方法，把组件立即从node中移除，然后再手动调用组件destroy方法。）