tiledmap object group optimize #5728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holycanvas
approved these changes
Nov 21, 2019
2youyou2
approved these changes
Nov 22, 2019
jareguo
reviewed
Nov 22, 2019
| let c = children[i]; | ||
| let cName = c._name; | ||
| let isUseless = imgExp.test(cName); | ||
| isUseless = isUseless || txtExp.test(cName); |
There was a problem hiding this comment.
直接 let isUseless = imgExp.test(cName) || txtExp.test(cName); 就行了吧
| // destroy useless node | ||
| let children = this.node.children; | ||
| let imgExp = /^img\d+$/; | ||
| let txtExp = /^text\d+$/; |
There was a problem hiding this comment.
感觉可以合并成一个正则性能应该更好点 /^(?:img|text)\d+$/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
EN:
Supports tileset including multi-map formats
Fixed the problem of incorrect image position of 45 ° Angle object group
cc.Node is used to achieve object group image, which is convenient for users to achieve occlusion effect
CN:
支持tileset包含多贴图格式
修复45度角object group图片位置不正确的问题
使用cc.Node 实现 object group图片，方便用户用它实现遮挡效果