fixed cc.RotateBy reverse error #5742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holycanvas
reviewed
Nov 15, 2019
cocos2d/actions/CCActionInterval.js
Outdated
| this._cloneDecoration(action); | ||
| this._reverseEaseList(action); | ||
| action.initWithDuration(this._duration, -this._deltaAngle); |
There was a problem hiding this comment.
这行放到
var action = new cc.RotateBy();
下面吧，不然被上面两行用到没设置过的action，可能有隐患
2youyou2
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Re: https://forum.cocos.org/t/cocos-creator-v2-2-1/85555/267?u=endevil
Changes:
*
fixed cc.RotateBy reverse function error code.
cc.RotateBy 的构造函数中有对 this._deltaAngle 进行取反的操作，所以导致调用
之后，this._deltaAngle 实际上没有发生变化，故导致了问题。
现在不利用 new cc.RotateBy() 来初始化数据，而是使用
这样就没有问题。