Improved type array to get the name of the code #5780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holycanvas
reviewed
Nov 22, 2019
| let type = value.constructor.name; | ||
| if (!type) { |
There was a problem hiding this comment.
iOS下不能赋值name，能直接用defineProperty设置的吧
There was a problem hiding this comment.
通过测试 defineProperty 也无法设置
jareguo
reviewed
Nov 22, 2019
jareguo
reviewed
Nov 22, 2019
jareguo
reviewed
Nov 22, 2019
jareguo
reviewed
Nov 23, 2019
| else if (constructor === Uint32Array) { return 'Uint32Array'; } | ||
| else if (constructor === Int32Array) { return 'Int32Array'; } | ||
| else if (constructor === Uint8Array) { return 'Uint8Array'; } | ||
| return ''; |
jareguo
approved these changes
Nov 23, 2019
sunnylanwanjun
reviewed
Nov 23, 2019
| !Int32Array.name && (Int32Array.name = 'Int32Array'); | ||
|
|
||
| !Uint8Array.name && (Uint8Array.name = 'Uint8Array'); | ||
| !Uint16Array.name && (Uint8Array.name = 'Uint16Array'); |
sunnylanwanjun
approved these changes
Nov 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Re: cocos-creator/2d-tasks#
Changes:
原因：由于之前为了处理 ie 上 TypeArray 获取到 name 为空的问题，在代码中设置了 TypeArray 的 name，但是 ios9 系统 name 是只读的属性如果设置的话就会报错，从而导致引擎代码跑在 ios9 系统上会崩溃