Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash loading scene while editBox is on editing on Mac #5804

Merged
merged 3 commits into from Nov 28, 2019

Conversation

PPpro
Copy link
Contributor

@PPpro PPpro commented Nov 28, 2019

Re: cocos/2d-tasks#2133

changeLog:

@PPpro PPpro requested review from holycanvas and zhefengzhang Nov 28, 2019
@PPpro PPpro changed the title 221 editbox fix crash loading scene while editBox is on editing on Mac Nov 28, 2019
@holycanvas
Copy link
Contributor

@holycanvas holycanvas commented Nov 28, 2019

Destroy的时候会触发 onDisable 么

@PPpro
Copy link
Contributor Author

@PPpro PPpro commented Nov 28, 2019

onDisable 会在 节点销毁 之前触发

@holycanvas
Copy link
Contributor

@holycanvas holycanvas commented Nov 28, 2019

之前之所以需要 #5748 的修改是因为当时的disable不会隐藏键盘?

@PPpro
Copy link
Contributor Author

@PPpro PPpro commented Nov 28, 2019

之前之所以需要 #5748 的修改是因为当时的disable不会隐藏键盘?

是因为 微信和原生上没有实现 disable,只有 web 上实现了。所以 web 没这个问题 cocos/2d-tasks#2082

@jareguo
Copy link
Member

@jareguo jareguo commented Nov 28, 2019

得同步给 Runtime 进行修改

@PPpro
Copy link
Contributor Author

@PPpro PPpro commented Nov 28, 2019

@@ -52,19 +55,24 @@ let EditBoxImplBase = cc.Class({
},

setTabIndex (index) {
// Only support on Web platform
// Only support on Web platform
Copy link
Member

@jareguo jareguo Nov 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个注释我觉得没有意义,子类有就是支持,没有就是不支持

@jareguo jareguo merged commit f943a87 into cocos:v2.2.1-release Nov 28, 2019
1 check was pending
@PPpro PPpro deleted the 221_editbox branch Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants