Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.3.0 particle texture stretch #5897

Merged
merged 4 commits into from Dec 18, 2019

Conversation

sunnylanwanjun
Copy link
Contributor

@sunnylanwanjun sunnylanwanjun commented Dec 13, 2019

解决元杰pr一些冲突:#5666

原生修改:
cocos-creator-packages/jsb-adapter#220
cocos/engine-native#1989

@sunnylanwanjun sunnylanwanjun changed the title V2.3.0 check particle texture V2.3.0 particle texture stretch Dec 13, 2019
@holycanvas holycanvas requested a review from jareguo Dec 16, 2019
@@ -345,6 +345,13 @@ var properties = {
visible: false
},

/**
* !#en Aspect ratio of particle.
* !#zh 粒子宽高比。
Copy link
Member

@jareguo jareguo Dec 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我不太明白这个宽高比是干什么用的?

Copy link
Member

@jareguo jareguo Dec 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议移除这个属性

@holycanvas holycanvas merged commit 3d04c64 into cocos:v2.3.0 Dec 18, 2019
1 check passed
@holycanvas
Copy link
Contributor

@holycanvas holycanvas commented Dec 18, 2019

cocos/2d-tasks#2134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants