Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed wechat uniform #6008

Merged
merged 1 commit into from Dec 30, 2019
Merged

Conversation

2youyou2
Copy link
Contributor

@2youyou2 2youyou2 commented Dec 30, 2019

Re: cocos/2d-tasks#2246

Changes:

  • fixed wechat uniform value

微信 ios 调用 gl.uniform1f(id, value), 如果 value 传的是 new Float32Array([0.5]) 会失败,需要直接传 number 才行。

@holycanvas
Copy link
Contributor

@holycanvas holycanvas commented Dec 30, 2019

这都能测出来

@holycanvas holycanvas merged commit c02641b into cocos:v2.3.0 Dec 30, 2019
1 check passed
@dumganhar
Copy link
Contributor

@dumganhar dumganhar commented Dec 30, 2019

这种低级 bug 都能有,微信就是牛逼。这个舔得好辛苦。

@2youyou2 2youyou2 deleted the v2.3.0-fixed-wechat-uniform branch Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants