add tween syntactic sugar #6327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2youyou2
reviewed
Mar 13, 2020
| @@ -498,6 +500,10 @@ var Component = cc.Class({ | |||
| }, | |||
|
|
|||
| _onPreDestroy () { | |||
| if (ActionManagerExist) { | |||
| cc.director.getActionManager().removeAllActionsFromTarget(this); | |||
There was a problem hiding this comment.
节点已经在 _onPreDestroy 里停止 action 了。
我在考虑是不是需要在 CCObject 里面做，不过这样很多无关的也会去判断了。
jareguo
reviewed
Mar 14, 2020
cocos2d/actions/tween.js
Outdated
| */ | ||
| tintBy (duration, color, opts) { | ||
| return this.by(duration, { color }, opts); | ||
| } |
There was a problem hiding this comment.
flipX, Y，还有后面这些单行实现的封装感觉意义不大啊，他想要代码这么抽象的话自己封装一个小函数也行
There was a problem hiding this comment.
原 action 有的都可以有，已经有用户抱怨这些函数为什么没了
There was a problem hiding this comment.
这些都是对 node 的扩展，要不加个 tween-extends-node.js，做个单独的扩展模块？
核心 tween 仍然是很干净的
cocos2d/actions/tween.js
Outdated
| * !#zh 按照贝塞尔路径设置目标的 position 属性。 | ||
| * @method bezierTo | ||
| * @param {number} duration | ||
| * @param {[cc.Vec2, cc.Vec2, cc.Vec2]} controls |
| @@ -498,6 +500,10 @@ var Component = cc.Class({ | |||
| }, | |||
|
|
|||
| _onPreDestroy () { | |||
| if (ActionManagerExist) { | |||
| cc.director.getActionManager().removeAllActionsFromTarget(this); | |||
holycanvas
reviewed
Mar 16, 2020
cocos2d/actions/tween.js
Outdated
| * !#zh 按照贝塞尔路径设置目标的 position 属性。 | ||
| * @method bezierBy | ||
| * @param {number} duration | ||
| * @param {[cc.Vec2, cc.Vec2, cc.Vec2]} controls |
There was a problem hiding this comment.
这样写，d.ts能正常识别么，cc.Vec2[] 会不会好一点
There was a problem hiding this comment.
这么写是强制传 3 个 cc.Vec2 的 array, cc.Vec2[] 没有限制个数
… v2.3.3-release-tween # Conflicts: # cocos2d/actions/tween.js
… v2.3.3-release-tween
jareguo
approved these changes
Mar 18, 2020
holycanvas
approved these changes
Mar 18, 2020
| type AllowedNames<Base, Type> = FlagExcludedType<Base, Type>[keyof Base]; | ||
| type KeyPartial<T, K extends keyof T> = { [P in K]?: T[P] }; | ||
| type OmitType<Base, Type> = KeyPartial<Base, AllowedNames<Base, Type>>; | ||
| type ConstructorType<T> = OmitType<T, Function>; |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Re: cocos/2d-tasks#2604
Changes:
利用泛型完善了 tween 的代码提示机制
