Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve VideoPlayer code for used to make the current time of each pl… #6360

Merged
merged 2 commits into from Mar 18, 2020

Conversation

knoxHuang
Copy link
Contributor

@knoxHuang knoxHuang commented Mar 18, 2020

…atform consistent

Re:
cocos/2d-tasks#2465
cocos/2d-tasks#2610
cocos/2d-tasks#2383

Changes:

  • 完善 videplayer 获取当前时间的代码,使每个平台获取到的当前时间保持一致

@holycanvas holycanvas requested a review from PPpro Mar 18, 2020
PPpro
PPpro approved these changes Mar 18, 2020
@@ -181,6 +181,15 @@ let VideoPlayer = cc.Class({
},
get: function () {
if (this._impl) {
// for used to make the current time of each platform consistent
if (this._currentStatus === EventType.STOPPED ||
Copy link
Contributor

@holycanvas holycanvas Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该要加NONE的判断吧,NONE也是返回0

@holycanvas holycanvas merged commit bd0d1f0 into cocos:v2.3.3-release Mar 18, 2020
1 check passed
@knoxHuang knoxHuang deleted the v2.3.3-fix-bug-1 branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants